-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapper for LAPACK _trexc methods (reordering of the Schur form) #12659
Conversation
Ptr{$elty}, Ptr{BlasInt}, Ptr{$elty}, Ptr{BlasInt}, | ||
Ptr{BlasInt}, Ptr{BlasInt}, | ||
Ptr{$elty}, Ptr{BlasInt}), | ||
&'V', &n, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, we don't restrict the options supported by LAPACK so I'd prefer a version with a compq
argument. I'd be fine with having a second method without the compq
argument that calls the first with compq=='V'
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that, I simply used the trsen
wrapper as a template. I can fix that one as well. Thank you for having a look at the commit, I'll correct what you suggested and add a few tests shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I see. It would be great if you could change that in trsen
as well and preferably in a separate commit.
Maybe try one or two reorderings and check that the eigenvalues are unaffected. The main point is to check that the wrapper is working. The two errors I've mentioned would probably have been found with such tests. |
I think it is fine to add these wrappers, but we should probably not add new functionality to 0.4 so please be patient. |
1a6063d
to
a0c4604
Compare
@andreasnoack I added the tests you suggested, but some of the checks fail for some reason I cannot understand. For instance, I get a
|
eab70ea
to
d044efc
Compare
Just to record that I solved the problem above. I'll just relax and wait for the end of the feature freeze. |
@mfasi the feature freeze is done since we've branched and this looks possible to merge. Is it ready to go? |
@kshyatt I think so, feel free to merge. |
Add wrapper for LAPACK _trexc methods (reordering of the Schur form)
@jakebolewski Great, thanks. |
I need this wrapper to implement some of the points of #5840 (I'm sure I need it for
funm
andunwm
). I'd be glad to add a few tests, but I have no idea how to test such an operation. Suggestions are welcome.