Speed up checkbounds #11843
Merged
Speed up checkbounds #11843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Also ensure that the one-index version is not less specific than the n-ary version.
mbauman
force-pushed
the
mb/fastercheckbounds
branch
from
ba48646 to
6a6d365
Compare
|
LGTM |
|
Man, I can't get anything through CI these days. Travis push failed because when I created this PR I thought I'd go easy on the travis queue and just push to my own fork. But then I forgot about that and updated the fork here on this repo, and then deleted it again. So that's not a problem. But Appveyor got stuck somewhere in the tests… @tkelman can I merge this guy? |
|
I think you should be able to, our fix from yesterday didn't do anything to make #11818 any better. As long as we get at least some green builds after merging this I don't think it's making it any worse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid the splatting allocations in checkbounds, and also ensures that the one-index version is not less specific than the n-ary version.