Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence ptr->int conversion warning in dump.c #11724

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Jun 16, 2015

I'm not entirely confident that this isn't warning us about a potential problem that needs a different fix, but FWIW this suppresses these longstanding warnings:

dump.c: In function ‘jl_save_system_image_to_stream’:
dump.c:1461:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
         write_int32(f, (int)reinit_list.items[i]);
                        ^
dump.c:1462:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
         write_int32(f, (int)reinit_list.items[i+1]);
                        ^

on my system. CC @vtjnash.

@yuyichao
Copy link
Contributor

Related #11363

@carnaval
Copy link
Contributor

one downside is that it did make the build less monotonous. we could add "witty compiling hints" like in the old maxis games

@timholy
Copy link
Member Author

timholy commented Jun 16, 2015

Thanks for finding that. I did a search for that warning, but forget to remove the "issue" tag.

@carnaval
Copy link
Contributor

"frobbing method tables...", "randomizing line numbers...", "computing type of the empty array..."

sorry, I need coffee

@timholy
Copy link
Member Author

timholy commented Jun 16, 2015

I think we should occasionally display messages like "repartitioning your hard drive, please wait...", chosen at random from a pool. We could have JSoC projects to come up with other good messages.

@yuyichao
Copy link
Contributor

@pao
Copy link
Member

pao commented Jun 16, 2015

Sadly, we killed our wiki some time ago (for valid reasons), so there's no natural place to collect these. "reticulating syntax..."

@vtjnash
Copy link
Member

vtjnash commented Jun 16, 2015

lgtm. thanks for doing this.

@vtjnash vtjnash merged commit bc2b557 into master Jun 16, 2015
@tkelman tkelman deleted the teh/silencewarning branch June 16, 2015 20:38
@StefanKarpinski
Copy link
Member

PyPy prints ASCII art fractals while building.

@kshyatt
Copy link
Contributor

kshyatt commented Jun 17, 2015

We could have JSoC projects to come up with other good messages.

"Cryptolocker installation beginning now"

@yuyichao
Copy link
Contributor

@StefanKarpinski and that's the PyPy FAQ I linked above.

@IainNZ
Copy link
Member

IainNZ commented Jun 17, 2015

"Reticulating splines" was always my favourite

@hayd
Copy link
Member

hayd commented Jun 20, 2015

Drawing a julia set seems appropriate (if a rip off of pypy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants