Fix #10041, and mostly fix #10010 #11021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multilib does still confuse cmake when it comes to finding openssl you will likely need to install libssl-dev:i386
|
will merge soon if no feedback - this might make #10977 a little easier to deal with |
This was referenced Jun 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
satisfy cmake in a different way
multilib libgit2 will likely have openssl issues, I blame debian's odd handling of multiarch libraries for making this more complicated than it should be (even with autotools this would likely be a mess), and multilib compilers in the first place just don't work as well as making a separate sysroot and using a cross-compile prefix (e.g. it should be
i686-linux-gnu-gcc, notgcc -m32, since the former would let you segregate libraries and tools likei686-linux-gnu-pkg-configbetter)