Generalize scalar indexing and implement reducedim without stagedfunctions #10524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes CartesianIndex indexing to allow a construct like
A[i::Int,I::CartesianIndex]
. This allows one to split out the innermost loop for special treatment. We did that already for the special case of@simd
, this just generalizes it in a way that allows one to exploit it for pure julia code, too.CC @Jutho, @mbauman. Some day we probably will want to go further, and allow full
getindex(A, indexes::Union(Integer, CartesianIndex)...)
. But for now we can't add that without generating ambiguity warnings, and I don't currently need the general case for anything.I then used this to rewrite the algorithms in
reducedim.jl
without using Base.Cartesian or any staged functions, with no loss of performance. (In fact, thesum!(R2, A)
case is about 15% faster.)Reference: #10310 (comment) and the comments above (this makes the "blows out of the water" comment no longer apply).