Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DArray's from Base #10334

Merged
merged 1 commit into from
Feb 27, 2015
Merged

Remove DArray's from Base #10334

merged 1 commit into from
Feb 27, 2015

Conversation

jakebolewski
Copy link
Member

It has been suggested that DArray's should be developed as an external package under the JuliaParalllel organization. (See https://github.com/JuliaParallel/DistributedArrays.jl)

Closes #10333.

cc @ViralBShah

@ivarne
Copy link
Member

ivarne commented Feb 26, 2015

Great!

If we do more of this, we'll have less discussion about backporting fixes/improvements to libraries that doesn't really need to follow the slow release schedule of Base.

@tkelman
Copy link
Contributor

tkelman commented Feb 26, 2015

Please don't make packages 0.4-only when they consist of removed functionality from base. Make them importable (and tested!) on both 0.3 and 0.4, but for 0.3 they should be a stub that just re-exports base functionality.

@samtkaplan
Copy link

In the Julia documentation, the section on parallel computing references the Julia documentation on distributed arrays. In particular, the sentence:

"Fortunately, distributed arrays can be used to get around this limitation, as we will see in the next section."

will need to be replaced by something like

"Fortunately, distributed arrays can be used to get around this limitation (see the DistributedArrays.jl package)."

I didn't see this change in the commits for this pull request. Apologies if I missed it. Here's a screen-grab from the docs:
image

@ViralBShah ViralBShah added the parallelism Parallel or distributed computation label Feb 26, 2015
@ViralBShah
Copy link
Member

Looks good.

@jakebolewski jakebolewski force-pushed the jcb/rmdarray branch 2 times, most recently from 40cb4b1 to 2a68a0d Compare February 27, 2015 02:04
- moves the DArray code to the DistributedArrays.jl package
  under the JuliaParallel organization

- removes the documentation for DArray's from stdlib and manual

- update tests, delete DArray examples, add NEWS entry
@tkelman
Copy link
Contributor

tkelman commented Feb 28, 2015

What's with the rush here? The package is not yet fully functional or tested, would have been considerably less disruptive to provide a usable (on both 0.3 and 0.4) replacement before merging this.

@timholy
Copy link
Member

timholy commented Feb 28, 2015

I can't comment about the DArray removal, but I'd characterize the Base.Graphics removal as mildly painful; even after several weeks we're still encountering issues here and there. Just a +1 for making sure these removals are done very carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parallelism Parallel or distributed computation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move DArrays from Base
6 participants