-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DArray
's from Base
#10334
Remove DArray
's from Base
#10334
Conversation
204b6a9
to
ecdbb45
Compare
Great! If we do more of this, we'll have less discussion about backporting fixes/improvements to libraries that doesn't really need to follow the slow release schedule of Base. |
Please don't make packages 0.4-only when they consist of removed functionality from base. Make them importable (and tested!) on both 0.3 and 0.4, but for 0.3 they should be a stub that just re-exports base functionality. |
Looks good. |
40cb4b1
to
2a68a0d
Compare
- moves the DArray code to the DistributedArrays.jl package under the JuliaParallel organization - removes the documentation for DArray's from stdlib and manual - update tests, delete DArray examples, add NEWS entry
2a68a0d
to
b84b0e2
Compare
Remove `DArray`'s from Base
What's with the rush here? The package is not yet fully functional or tested, would have been considerably less disruptive to provide a usable (on both 0.3 and 0.4) replacement before merging this. |
I can't comment about the DArray removal, but I'd characterize the Base.Graphics removal as mildly painful; even after several weeks we're still encountering issues here and there. Just a +1 for making sure these removals are done very carefully. |
It has been suggested that
DArray
's should be developed as an external package under the JuliaParalllel organization. (See https://github.com/JuliaParallel/DistributedArrays.jl)Closes #10333.
cc @ViralBShah