-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Add filtering behavior to whos() #10108
Conversation
Seems reasonable to me. @JeffBezanson? |
I wish we can also show memory consumption... |
Just changed the default filter objects so modules are only hidden when the plain |
23807e2
to
59dcf82
Compare
ac03d67
to
7b6d9e6
Compare
Defaults to not displaying modules
I figure the 3 month anniversary is as good a time as any to bring this back up. @StefanKarpinski, @ViralBShah, any other feedback? This appears to be a case of quite limited interest. |
I think the functionality is useful but I'm not sure about the API. Since it's a function intended for interactive usage, however, it wouldn't be too awful to change it later if we come up with better. |
I agree, it is somewhat awkward, but there's basically zero cost to changing it at any time. I'd be happy to implement other approaches. I think there's some minor degree of importance, and not just personal preference, to having |
Aside from wishing for additional features, do you have any opinions about this, @ViralBShah? |
I like this idea, but I agree that the API is a little funky. I actually asked a question on Stack Overflow looking for similar behavior. I'd also like to see an option for returning a symbol array rather than printing. |
This change adds a
filter
keyword argument to thewhos
methods that takes one or more types that should not be displayed. It changes the default behavior to not displayModule
types.I raised this issue in #9902 but didn't get any discussion going. I don't see any real use-case of needing to see what modules have been imported into
Main
, and as my example in the issue shows, it can be quite a large number. I think it makes sense to keep it less cluttered and to allow the current behavior through an additional argument. Plus it allows for other interesting options like excludingFunction
s and/orDataType
s.