Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I feel naming inconsistency with beginswith. #9578

Closed
bicycle1885 opened this issue Jan 3, 2015 · 9 comments
Closed

I feel naming inconsistency with beginswith. #9578

bicycle1885 opened this issue Jan 3, 2015 · 9 comments
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@bicycle1885
Copy link
Member

We have the beginswith function to check whether a string begins with a given prefix.
This is good, I often use it. But its name looks inconsistent compared to other function names in Julia.

To list some, other functions use "start" in their name:

and no other functions use the word "begin" except beginswith.
So I believe it would be better to rename beginswith to startswith for consistency.
I want to know how you feel about this (maybe too trivial to think).

As a reference, Python has the str.startswith method, which works in the same way as beginswith does.

@kmsquire
Copy link
Member

kmsquire commented Jan 3, 2015

I have to say that this has bugged me slightly for about two years, but never enough to try to come up with a justification. So, +1!

@mpastell
Copy link
Contributor

mpastell commented Jan 3, 2015

+1 for renaming

@ivarne ivarne added the help wanted Indicates that a maintainer wants help on an issue or pull request label Jan 3, 2015
@bicycle1885
Copy link
Member Author

I'm almost ready to create a pull request.

@bicycle1885
Copy link
Member Author

This is it: #9583 (didn't GitHub automatically create a cross-link to a referring pull request?)

@ivarne
Copy link
Member

ivarne commented Jan 3, 2015

Apparently not when you referenced the issue number in the headline, not the body of the pull request.

@JeffBezanson
Copy link
Member

🚲 🏠

@kmsquire
Copy link
Member

kmsquire commented Jan 3, 2015

Is there any way to turn that into a tag? ;-)

@jiahao
Copy link
Member

jiahao commented Jan 3, 2015

That tag would probably get used on half the issues...

@bicycle1885
Copy link
Member Author

😑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

No branches or pull requests

6 participants