Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove uint_mapping? #8539

Closed
simonster opened this issue Oct 1, 2014 · 3 comments
Closed

remove uint_mapping? #8539

simonster opened this issue Oct 1, 2014 · 3 comments

Comments

@simonster
Copy link
Member

uint_mapping appears to be broken by #8420, but it also appears that there are no callers in Base, although it is used by the radix sort implementation in SortingAlgorithms.jl. Shall I move it over there?
@StefanKarpinski
Copy link
Member

That's probably for the best. cc: @kmsquire

@JeffBezanson
Copy link
Member

Yes please move it.

@kmsquire
Copy link
Member

kmsquire commented Oct 1, 2014

It could actually be used in all FP sorting--when I implemented it, I think it was slightly faster than the current implementation. But since it relies on the bit patterns for sorting, it doesn't have the same behavior when dealing with NaN and Inf.

But anyway, it is only really needed by RadixSort, so moving it there is best.

simonster added a commit to JuliaCollections/SortingAlgorithms.jl that referenced this issue Oct 1, 2014
@simonster
Move uint_mapping here from Base and fix it for JuliaLang/julia#8420
ce5c2bd 
I also got rid of the manual inlining since the compiler now appears to
inline everything on its own.

Fixes #6. Ref JuliaLang/julia#8539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StefanKarpinski @kmsquire @simonster @JeffBezanson