Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-julia-16.0.6-2.tar.gz checksum fail #53399

Closed
semarie opened this issue Feb 20, 2024 · 2 comments · Fixed by #53870
Closed

llvm-julia-16.0.6-2.tar.gz checksum fail #53399

semarie opened this issue Feb 20, 2024 · 2 comments · Fixed by #53870
Assignees
@gbaraldi
Labels
building Build system, or building Julia or its dependencies
Milestone
1.11

Comments

@semarie
Copy link
Contributor

semarie commented Feb 20, 2024

While building julia with USE_BINARYBUILDER=0, the llvm tarball fetched is llvm-julia-16.0.6-2.tar.gz, and it failed the checksum check.

the deps/checksums/llvm has been updated by #53195, and the downloaded file currently match the previous hash.

I am unsure if:

  • the fetched file isn't the right one because the PR updated llvm to 16.0.6+4 (and we are fetching 16.0.6-2)
  • the fetched file isn't the right one because the file should have been updated too (and it wasn't)
  • the fetched file is the right one and the checksum change is unintented

Cc @gbaraldi and @vchuravy who worked on the llvm update
@inkydragon inkydragon added the building Build system, or building Julia or its dependencies label Feb 20, 2024
@vchuravy
Copy link
Member

The source hash should not have changed. Since https://github.com/JuliaLang/llvm-project/tags is still on 16.0.6-2 and 16.0.6+4 was a pure build change in Yggdrasil. I am unsure why contrib/update_checksums messed that up.

@vchuravy vchuravy added this to the 1.11 milestone Feb 20, 2024
@ararslan
Copy link
Member

ararslan commented Mar 1, 2024

We can't build the source distribution tarballs for v1.11.0-alpha1 because of this as they require USE_BINARYBUILDER=0.

Zentrik added a commit to Zentrik/julia that referenced this issue Mar 26, 2024
@Zentrik
Revert change to checksum for llvm-julia
4718e57 
Should fix JuliaLang#53399. I think this is the correct fix.
@Zentrik Zentrik mentioned this issue Mar 26, 2024
Merged
vchuravy pushed a commit that referenced this issue Mar 29, 2024
@Zentrik
Revert change to checksum for llvm-julia (#53870)
b2e8eb2 
Should fix #53399. I think this is the correct fix.
Makes it so you can build Julia with `USE_BINARYBUILDER=0`.
KristofferC pushed a commit that referenced this issue Apr 9, 2024
@Zentrik
Revert change to checksum for llvm-julia (#53870)
6f8e78d 
Should fix #53399. I think this is the correct fix.
Makes it so you can build Julia with `USE_BINARYBUILDER=0`.

(cherry picked from commit b2e8eb2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbaraldi gbaraldi

Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
1.11
Development

Successfully merging a pull request may close this issue.

Revert change to checksum for llvm-julia Zentrik/julia
5 participants
@vchuravy @inkydragon @ararslan @semarie @gbaraldi