Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing "`\\" crashes the REPL immediately #51985

Closed
vtjnash opened this issue Nov 1, 2023 · 2 comments · Fixed by #52009
Closed

typing "`\\" crashes the REPL immediately #51985

vtjnash opened this issue Nov 1, 2023 · 2 comments · Fixed by #52009
Labels
regression Regression in behavior compared to a previous version REPL Julia's REPL (Read Eval Print Loop)
Milestone
1.11

Comments

@vtjnash
Copy link
Member

vtjnash commented Nov 1, 2023 •
edited by DilumAluthge
Loading 

julia> `\\┌ Error: Error in the keymap
│   exception = (BoundsError("`\\\\", 0:3), Union{Ptr{Nothing}, Base.InterpreterIP}[Ptr{Nothing} @0x00007fc132a83da8, Ptr{Nothing} @0x00007fc132a62997, Ptr{Nothing} @0x00007fc14a6c9a9e, Ptr{Nothing} @0x00007fc132b7b744, Ptr{Nothing} @0x00007fc132ad156e, Ptr{Nothing} @0x00007fc14a6c9a9e, Ptr{Nothing} @0x00007fc14a6db07d, Ptr{Nothing} @0x00007fc132b70b6c, Ptr{Nothing} @0x00007fc132ad8446, Ptr{Nothing} @0x00007fc14a6c9a9e, Ptr{Nothing} @0x00007fc132b083f0, Ptr{Nothing} @0x00007fc132ab1b20, Ptr{Nothing} @0x00007fc1329bcd5e, Ptr{Nothing} @0x00007fc14a6c9a9e, Ptr{Nothing} @0x00007fc132a779ee, Ptr{Nothing} @0x00007fc132a856cd, Ptr{Nothing} @0x00007fc132a58636, Ptr{Nothing} @0x00007fc14a6c9a9e, Ptr{Nothing} @0x00007fc14a6f0bb1])
└ @ REPL.LineEdit /home/vtjnash/julia1/usr/share/julia/stdlib/v1.11/REPL/src/LineEdit.jl:2817

(regression introduced in v1.10 from my brief testing, though v1.10 requires pressing tab to get the crash)
@vtjnash vtjnash added REPL Julia's REPL (Read Eval Print Loop) regression Regression in behavior compared to a previous version labels Nov 1, 2023
@vtjnash vtjnash added this to the 1.10 milestone Nov 1, 2023
@IanButterworth IanButterworth mentioned this issue Nov 3, 2023
Merged
@IanButterworth
Copy link
Member

IanButterworth commented Nov 8, 2023 •
edited
Loading

This is more of an issue on 1.11 and perhaps shouldn't be on the 1.10 milestone as a blocker given it requires a tab press?

@ufechner7
Copy link

ufechner7 commented Nov 9, 2023 •
edited
Loading

I am not able to reproduce this issue with Julia 1.10.0-rc1 on Windows. Which key sequence should result in a crash?

@IanButterworth IanButterworth modified the milestones: 1.10, 1.11 Nov 9, 2023
vtjnash added a commit that referenced this issue Nov 15, 2023
@IanButterworth @vtjnash
[REPL] fix computation of startpos for path completions (#52009)
5edcdc5 
Fixes #51985

Ensure that the REPL completions escape and unescape text correctly,
using the correct functions, and accounting for exactly what the user
has currently typed.

The old broken method is left around for Pkg, since it has an
over-reliance on it returning incorrect answers. Once Pkg is fixed, we
can delete that code.

Co-authored-by: Jameson Nash <[email protected]>
KristofferC pushed a commit that referenced this issue Nov 27, 2023
@IanButterworth @KristofferC
[REPL] fix computation of startpos for path completions (#52009)
dc2c4f1 
Fixes #51985

Ensure that the REPL completions escape and unescape text correctly,
using the correct functions, and accounting for exactly what the user
has currently typed.

The old broken method is left around for Pkg, since it has an
over-reliance on it returning incorrect answers. Once Pkg is fixed, we
can delete that code.

Co-authored-by: Jameson Nash <[email protected]>
(cherry picked from commit 5edcdc5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression Regression in behavior compared to a previous version REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
1.11
Development

Successfully merging a pull request may close this issue.

fix completion that resulted in startpos of 0 for `\\ IanButterworth/julia
3 participants
@vtjnash @IanButterworth @ufechner7