-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many packages asserts with: Assertion oldentry->max_world == ~(size_t)0 && "method cannot be added at the same time as method deleted"' failed.
#50451
Comments
MWE, requiring actual packages and extensions, and running with assertions enabled:
module ConstructionBase
constructorof() = nothing
end
module StaticArrays
end
module ConstructionBaseStaticArraysExt
using ConstructionBase
ConstructionBase.constructorof(::Type) = nothing
ConstructionBase.constructorof(::Type{<:Integer}) = nothing
end Finally, using ConstructionBase
ConstructionBase.constructorof(::Type{<:Integer}) = nothing
using StaticArrays |
Fixes #50451. Fortunately, this wasn't anything more than an unnecessary assertion.
Not fixed; the assertion has now just changed to:
It also looks like more package trigger the new form of that assertion now? |
The Pkg.precompile code now intentionally suppresses a lot of essential information, which seems to be a severe regression to me, but the PR to fix it is sitting idle (JuliaLang/Pkg.jl#3536). Running this manually results in:
And this is exactly (half of) the reason it prints this error. I can push a fix to make that error more clear though. |
Previously, this was only a WARNING message, which was often missed during CI runs. Closes #50451
Many packages now assert with something similar to:
Example PkgEval log: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/c9a32f4_vs_e4ee485/ConstructionBaseExtras.primary.log
I think this happens when a method is overwritten but I didn't check all cases.
The text was updated successfully, but these errors were encountered: