-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcext test is often failing #50434
Comments
Looked briefly into this, definitely a release blocker. |
Ensure `internal_obj_base_ptr` checks whether objects past freelist pointer are in freelist. Fixes #50434
I just stumbled over this issue. Yes we noticed in GAP.jl resp Oscar.jl new crashes related to our gcext code, see oscar-system/Oscar.jl#2543 I don't know yet if these are related or a separate issue (nor do CC @benlorenz |
Is this reproducible on the latest master? |
I am not sure, the problem with these issues is that we in general have a hard time reproducing them outside of CI (the CI runners have comparatively low memory compared to our dev machines, and exhibit the problems much more frequently). The last one I am explicitly aware of was 5 days ago, the same day PR #50533 was merged, so perhaps that resolved it? In general it would be great to get a ping when you observe gcext failures, because they almost always affect us, and then we can coordinate testing. If you wish I'll be happy to do the reverse (so we far we usually try to first figure out more about the problem in case it is on our side; but with the recent fast pace of GC changes, maybe it'd be better to notify you immediately? But we don't want to bother you guys unduly...) |
The gcext test is failing. A quick fix would be to change the
length(errlines) == 0
check to useisempty(errlines)
instead, which has special printing in Test and would likely quickly reveal the issue.example: https://buildkite.com/julialang/julia-master/builds/25595#01892862-243e-4599-b390-cf005b815ea4
The text was updated successfully, but these errors were encountered: