Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Intermittent failure in misc.jl 27164 test #46360

Closed
Keno opened this issue Aug 15, 2022 · 2 comments · Fixed by #46941
Closed

CI: Intermittent failure in misc.jl 27164 test #46360

Keno opened this issue Aug 15, 2022 · 2 comments · Fixed by #46941
Labels
ci Continuous integration

Comments

@Keno
Copy link
Member

Keno commented Aug 15, 2022 



Error in testset misc:
--
  | Test Failed at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-2.0/build/default-macmini-aarch64-2-0/julialang/julia-master/julia-fde3a68005/share/julia/test/misc.jl:249
  | Expression: x27164[] == 2
  | Evaluated: 1 == 2

https://buildkite.com/julialang/julia-master/builds/14752#0182a08a-0771-4394-890e-fe4e703e171a
@Keno
Copy link
Member Author

Keno commented Aug 15, 2022

This is the test from #27164

@Keno Keno added the ci Continuous integration label Aug 15, 2022
@Keno Keno changed the title CI: Intermittent failure in miscl.jl 27164 test CI: Intermittent failure in misc.jl 27164 test Aug 16, 2022
@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 2, 2022

Looks like a timing race? The test is checking whether sleep(1) (which is started first) or sleep(0.05) (which is nominally shorter) returns first

vtjnash added a commit that referenced this issue Sep 28, 2022
@vtjnash
avoid timing race in async test
06d5d68 
This is the test from #27164.

The test was checking whether sleep(1) (which is started first) or
sleep(0.05) (which is nominally shorter) returned first. Switch the
order so that the short sleep should always end first.

Fixes #46360
@vtjnash vtjnash mentioned this issue Sep 28, 2022
Merged
vtjnash added a commit that referenced this issue Sep 29, 2022
@vtjnash
avoid timing race in async test
9cc6faf 
This is the test from #27164.

The test was checking whether sleep(1) (which is started first) or
sleep(0.05) (which is nominally shorter) returned first. Use an Event
instead so that they are explicitly ordered.

Fixes #46360
vtjnash added a commit that referenced this issue Sep 29, 2022
@vtjnash
avoid timing race in async test (#46941)
f346735 
This is the test from #27164.

The test was checking whether sleep(1) (which is started first) or
sleep(0.05) (which is nominally shorter) returned first. Use an Event
instead so that they are explicitly ordered.

Fixes #46360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid timing race in async test JuliaLang/julia
2 participants
@vtjnash @Keno