include_string (etc.) should have an argument to specify the module to evaluate in

[stevengj]

Similar to eval, the include_string function (and other include functions) should have a way to specify what module the string is evaluated in. Maybe just an optional third argument?

I noticed this today because a student wanted to use include(....) to load a file, but instead of looking in the current directory it was looking in ~/.julia/IJulia/src: apparently since include_string is being called from a function in the IJulia module then it is evaluated in that module rather than in Main as I intended.

cc: @JeffBezanson

[Keno]

Also Keno/REPL.jl#2

[JeffBezanson]

Hmm, this is because task_local_storage()[:SOURCE_PATH] is set during loading of kernel.jl, and we never get out of that file so it stays set that way. It doesn't have to be that way, since the inputs actually run in a separate task, but source_path searches parent tasks. Maybe we should change that behavior. @StefanKarpinski

[StefanKarpinski]

It seems to me like IJulia's kernel.jl should probably unset task_local_storage()[:SOURCE_PATH] so as to better emulate running in a script or the repl. See if calling delete!(task_local_storage(),:SOURCE_PATH) at the top of kernel.jl works.

[JeffBezanson]

That is a good workaround for now at least.

[StefanKarpinski]

I'm not even sure it's a workaround – the point is that kernel.jl is a script emulating the julia system itself. Perhaps we should expose this as clear_source_path() or something like that, but let's see if it works first.

[stevengj]

The workaround seems to work, though it is a bit ugly.

[JeffBezanson]

The include* functions now have module arguments.