Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VecElement segfaults with union element #29864

Closed
MikeInnes opened this issue Oct 31, 2018 · 0 comments · Fixed by #34805
Closed

VecElement segfaults with union element #29864

MikeInnes opened this issue Oct 31, 2018 · 0 comments · Fixed by #34805
Labels
bug Indicates an unexpected problem or unintended behavior missing data Base.missing and related functionality

Comments

@MikeInnes
Copy link
Member 

julia> versioninfo()
Julia Version 1.0.2-pre.0
Commit 4aea3d2b7c (2018-09-30 15:02 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin18.0.0)
  CPU: Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.0 (ORCJIT, skylake)

julia> VecElement{Union{Int,Nothing}}(1)

signal (11): Segmentation fault: 11
in expression starting at no file:0
_ZN4llvm11PointerType3getEPNS_4TypeEj at /Users/mike/projects/julia/usr/lib/libLLVM.dylib (unknown line)
_ZN4llvm17GetElementPtrInst16getGEPReturnTypeEPNS_4TypeEPNS_5ValueENS_8ArrayRefIS4_EE at /Users/mike/projects/julia/usr/lib/libLLVM.dylib (unknown line)
_ZN4llvm25ConstantFoldGetElementPtrEPNS_4TypeEPNS_8ConstantEbNS_8OptionalIjEENS_8ArrayRefIPNS_5ValueEEE at /Users/mike/projects/julia/usr/lib/libLLVM.dylib (unknown line)
_ZN4llvm12ConstantExpr16getGetElementPtrEPNS_4TypeEPNS_8ConstantENS_8ArrayRefIPNS_5ValueEEEbNS_8OptionalIjEES2_ at /Users/mike/projects/julia/usr/lib/libLLVM.dylib (unknown line)
@JeffBezanson JeffBezanson added bug Indicates an unexpected problem or unintended behavior missing data Base.missing and related functionality labels Oct 31, 2018
@JeffBezanson JeffBezanson added this to the 1.0.x milestone Nov 4, 2018
vtjnash added a commit that referenced this issue Feb 18, 2020
@vtjnash
codegen: fix segfaults with VecElement with union element
73e2327 
We were being too aggressive at unwrapping these: since they are already
unwrapped once, they need to be treated almost as a normal struct.

fixes #29864
vtjnash added a commit that referenced this issue Feb 18, 2020
@vtjnash
codegen: fix segfaults with VecElement with union element
81f8e5e 
We were being too aggressive at unwrapping these: since they are already
unwrapped once, they need to be treated almost as a normal struct.

fixes #29864
@vtjnash vtjnash mentioned this issue Feb 18, 2020
Merged
JeffBezanson pushed a commit that referenced this issue Feb 19, 2020
@vtjnash
codegen: fix segfaults with VecElement with union element (#34805)
8720530 
We were being too aggressive at unwrapping these: since they are already
unwrapped once, they need to be treated almost as a normal struct.

fixes #29864
KristofferC pushed a commit that referenced this issue Feb 19, 2020
@vtjnash @KristofferC
codegen: fix segfaults with VecElement with union element (#34805)
967bc47 
We were being too aggressive at unwrapping these: since they are already
unwrapped once, they need to be treated almost as a normal struct.

fixes #29864

(cherry picked from commit 8720530)
birm pushed a commit to birm/julia that referenced this issue Feb 22, 2020
@vtjnash @birm
codegen: fix segfaults with VecElement with union element (JuliaLang#…
e4cb017 
…34805)

We were being too aggressive at unwrapping these: since they are already
unwrapped once, they need to be treated almost as a normal struct.

fixes JuliaLang#29864
KristofferC pushed a commit that referenced this issue Apr 11, 2020
@vtjnash @KristofferC
codegen: fix segfaults with VecElement with union element (#34805)
889cae5 
We were being too aggressive at unwrapping these: since they are already
unwrapped once, they need to be treated almost as a normal struct.

fixes #29864
BioTurboNick pushed a commit to BioTurboNick/julia that referenced this issue Apr 13, 2020
@vtjnash @BioTurboNick
codegen: fix segfaults with VecElement with union element (JuliaLang#…
bbee2ec 
…34805)

We were being too aggressive at unwrapping these: since they are already
unwrapped once, they need to be treated almost as a normal struct.

fixes JuliaLang#29864

(cherry picked from commit 8720530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior missing data Base.missing and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codegen: fix segfaults with VecElement with union element JuliaLang/julia
2 participants
@JeffBezanson @MikeInnes