Add settings to CredentialPayload #23690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
added
deprecation
omus
force-pushed
the
cv/libgit2-allow-keywords
branch
2 times, most recently
from
fea2da7
to
0e307e3
Compare
|
Added some comments for the allow fields. I also did a rebase and dealt with the NEWS conflict. |
rofinn
suggested changes
Sep 14, 2017
NEWS.md
Outdated
| @@ -443,6 +443,10 @@ Deprecated or removed | |||
| this is not true. If you are certain you need the old behavior, it is temporarily available | |||
| as `Base._isleaftype` ([#17086]). | |||
|
|
|||
| * Constructors for `LibGit2.UserPasswordCredentials` and `LibGit2.SSHCredentials` no longer take a | |||
| `prompt_if_incorrect` argument. Controlling prompting behavior has been moved to | |||
| `LibGit2.CredentialPayload`. | |||
There was a problem hiding this comment.
Might want to also clarify a few points:
prompt_if_incorrecthas also been renamed toallow_promptin theCredentialPayloaduse_ssh_agentis now a Bool vsChar.
There was a problem hiding this comment.
I'll update the news to mention allow_prompt. As for change to use_ssh_agent in CredentialPayload I'll avoid mentioning that since the entire CredentialPayload is new to 0.7.
Removes `prompt_if_incorrect` field from `SSHCredentials` and `UserPasswordCredentials` and replaces it with the `allow_prompt` field in `CredentialPayload`. Note that allowing prompting is now the default. Note: Although we can deprecate when people specify a boolean for the `prompt_if_incorrect` parameter we cannot detect if people were reliant on prompting being disabled by default.
omus
force-pushed
the
cv/libgit2-allow-keywords
branch
from
0e307e3
to
e27c77d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to control whether the SSH agent or prompting should be allowed when authenticating. Removes the last piece of payload state stored in
UserPasswordCredentialsandSSHCredentials. With the removal ofprompt_if_incorrectwe can deprecate most of the original constructors.Part of #20725.