Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing bounds errors with omitted indices over trailing 0-length dimensions #23629

Closed
mbauman opened this issue Sep 7, 2017 · 1 comment
Closed

Missing bounds errors with omitted indices over trailing 0-length dimensions #23629

mbauman opened this issue Sep 7, 2017 · 1 comment
Assignees
@mbauman
Labels
arrays [a, r, r, a, y, s] bug Indicates an unexpected problem or unintended behavior

Comments

@mbauman
Copy link
Sponsor Member

mbauman commented Sep 7, 2017

I won't have a chance to address this this week, but I wanted to make sure it didn't get lost. On both 0.6 and master:

julia> rand(2,3,0)[2,3]
2.188348641e-314

julia> checkbounds(rand(2,3,0), 2, 3)
# nothing

Both should throw BoundsErrors (the implementations are distinct, but both have the same bug).
@mbauman mbauman self-assigned this Sep 7, 2017
@mbauman mbauman added bug Indicates an unexpected problem or unintended behavior arrays [a, r, r, a, y, s] backport pending 0.6 labels Sep 7, 2017
mbauman added a commit that referenced this issue Sep 8, 2017
@mbauman
Fix and test #23629
f9826c5
mbauman added a commit that referenced this issue Sep 15, 2017
@mbauman
Fix and test #23629
152f8ec
mbauman added a commit that referenced this issue Sep 15, 2017
@mbauman
[Release-0.6] Fix missing bounds checks for trailing zero dimensions
8ea10d3 
This fixes issue #23629 for 0.6. It is done independently from the fix for master (in #23628) due to all the deprecation changes.
@mbauman mbauman mentioned this issue Sep 15, 2017
Merged
ararslan pushed a commit that referenced this issue Sep 18, 2017
@mbauman @ararslan
Fix missing bounds checks for trailing zero dimensions (#23723)
4cc3b41 
This fixes issue #23629 for 0.6. It is done independently from the fix for master (in #23628) due to all the deprecation changes.
ararslan pushed a commit that referenced this issue Sep 18, 2017
@mbauman @ararslan
Fix missing bounds checks for trailing zero dimensions (#23723)
7861fe8 
This fixes issue #23629 for 0.6. It is done independently from the fix for master (in #23628) due to all the deprecation changes.
mbauman added a commit that referenced this issue Sep 19, 2017
@mbauman
Fix and test #23629
d1a0879 
Ensure bounds are checked over trailing zero dimensions
@mbauman mbauman closed this as completed Sep 22, 2017
@mbauman
Copy link
Sponsor Member Author

mbauman commented Sep 22, 2017

Fixed in #23628.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbauman mbauman

Labels
arrays [a, r, r, a, y, s] bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbauman