Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce --banner={default|yes|no} option to control banner printing #23342

Closed
StefanKarpinski opened this issue Aug 19, 2017 · 0 comments
Closed

Introduce --banner={default|yes|no} option to control banner printing #23342

StefanKarpinski opened this issue Aug 19, 2017 · 0 comments
Labels
good first issue Indicates a good issue for first-time contributors to Julia needs decision A decision on this change is needed
Milestone
0.7

Comments

@StefanKarpinski
Copy link
Member

The -q / --quiet option is kind of strangely named since all it does is suppress banner printing. We should probably rename it to the more-obvious --banner={yes|no} option style.
@StefanKarpinski StefanKarpinski added good first issue Indicates a good issue for first-time contributors to Julia help wanted Indicates that a maintainer wants help on an issue or pull request labels Aug 19, 2017
@StefanKarpinski StefanKarpinski added this to the 1.0 milestone Aug 19, 2017
@HarrisonGrodin HarrisonGrodin mentioned this issue Aug 19, 2017
Merged
@yuyichao yuyichao changed the title change -q --quiet to --banner=no Introduce --banner={default|yes|no} option to control banner printing Aug 22, 2017
yuyichao added a commit that referenced this issue Aug 22, 2017
@yuyichao
Revert "Replace --quiet with --banner (#23343)"
3ee9cc5 
This reverts commit dcb46b3.

Fix #23380
Reopen #23342
yuyichao added a commit that referenced this issue Aug 22, 2017
@yuyichao
Revert "Replace --quiet with --banner (#23343)"
02bbd40 
This reverts commit dcb46b3
and clarify the help message of `--quiet`.

Fix #23380
Reopen #23342
@yuyichao yuyichao mentioned this issue Aug 22, 2017
Closed
@yuyichao yuyichao reopened this Aug 22, 2017
@yuyichao yuyichao added needs decision A decision on this change is needed and removed help wanted Indicates that a maintainer wants help on an issue or pull request labels Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors to Julia needs decision A decision on this change is needed
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
2 participants
@StefanKarpinski @yuyichao