RFC: deprecate reading functions that accept both a cmd and stdin #22762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
deprecation
tkelman
reviewed
Jul 11, 2017
| return String(read(cmd, stdin)) | ||
| end | ||
|
|
||
| function writeall(cmd::AbstractCmd, stdin::AbstractString, stdout::Redirectable=DevNull) |
…uments remove unused/unexported `writeall`, fixes #18834
Sacha0
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are strange methods because (1) they violate orthogonality, and (2) they conflict with other uses of the second argument (normally we have
read(io, type), but here we haveread(cmd, stdin)). I don't think these are widely used.Also removed the mystery function
writeallthat doesn't seem to be referenced anywhere.