Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writeall referenced in docs, but doesn't exist #18834

Closed
rofinn opened this issue Oct 7, 2016 · 5 comments
Closed

writeall referenced in docs, but doesn't exist #18834

rofinn opened this issue Oct 7, 2016 · 5 comments
Labels
docs This change adds or pertains to documentation good first issue Indicates a good issue for first-time contributors to Julia Hacktoberfest Good for Hacktoberfest participants io Involving the I/O subsystem: libuv, read, write, etc.

Comments

@rofinn
Copy link
Contributor

rofinn commented Oct 7, 2016

On line 325 of docs/manual/running-external-programs.rst the example solution is using a writeall(proc, x) function that no longer exists.

@kshyatt kshyatt added docs This change adds or pertains to documentation io Involving the I/O subsystem: libuv, read, write, etc. good first issue Indicates a good issue for first-time contributors to Julia Hacktoberfest Good for Hacktoberfest participants labels Oct 7, 2016
@akaysh
Copy link
Contributor

akaysh commented Jan 3, 2017

@Rory-Finnegan Should this reference be completely removed or something else is required in its place?
As it is referenced as one of the ways to avoid deadlock by separation or reading and writing operations in the pipeline, I think there should be an existing alternative way to do that.

@rofinn
Copy link
Contributor Author

rofinn commented Jan 3, 2017

@akaysh I think you should just be able to replace writeall(...) with write(...) the deadlock avoidance is due to using readstring vs wait.

@akaysh
Copy link
Contributor

akaysh commented Jan 4, 2017

@Rory-Finnegan I found the writeall function in process.jl which asynchronously runs commands using write function.
Is it still required to replace the reference?

@rofinn
Copy link
Contributor Author

rofinn commented Jan 4, 2017

Well it isn't exported, so the example should either be removed or the code should explicitly do a Base.writeall.

@akaysh
Copy link
Contributor

akaysh commented Jan 11, 2017

@Rory-Finnegan #19975

JeffBezanson added a commit that referenced this issue Jul 11, 2017
…uments

remove unused/unexported `writeall`, fixes #18834
jeffwong pushed a commit to jeffwong/julia that referenced this issue Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation good first issue Indicates a good issue for first-time contributors to Julia Hacktoberfest Good for Hacktoberfest participants io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

No branches or pull requests

3 participants