Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change parsing of ~ from macro to operator #20406

Closed
2 of 3 tasks
StefanKarpinski opened this issue Feb 2, 2017 · 5 comments
Closed
2 of 3 tasks

change parsing of ~ from macro to operator #20406

StefanKarpinski opened this issue Feb 2, 2017 · 5 comments
Labels
breaking This change will break code parser Language parsing and surface syntax
Milestone

Comments

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Feb 2, 2017

From #19598:

@StefanKarpinski StefanKarpinski added this to the 0.6.0 milestone Feb 2, 2017
@JeffBezanson JeffBezanson added the parser Language parsing and surface syntax label Feb 2, 2017
@JeffBezanson
Copy link
Member

Currently this has n-ary parsing; x ~ y ~ z is parsed as a single 3-argument call. Do we want to keep that?

@ararslan
Copy link
Member

ararslan commented Feb 2, 2017

Regarding updating DataFrames, the situation is a little complex, but we're getting there. Ref JuliaData/DataFrames.jl#1154 (comment)

@ararslan
Copy link
Member

ararslan commented Feb 2, 2017

@JeffBezanson I've never seen that used in the wild (and indeed I didn't even know about it) so I'd guess that if that behavior were removed with the parsing change, few people if anyone would notice. So if it's simpler to take it out then I'd say go for it.

@ararslan ararslan added the breaking This change will break code label Feb 2, 2017
@StefanKarpinski
Copy link
Member Author

Good point: try parsing as binary and see if anyone screams 😬

@GunnarFarneback
Copy link
Contributor

For what it's worth I have made use of the n-ary parsing, but it's moot when the macro parsing goes away.

JeffBezanson added a commit that referenced this issue Feb 3, 2017
fix #20406, parse infix `~` as a normal operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change will break code parser Language parsing and surface syntax
Projects
None yet
Development

No branches or pull requests

4 participants