Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in isa parsing in catch #19987

Closed
yuyichao opened this issue Jan 12, 2017 · 3 comments
Closed

Change in isa parsing in catch #19987

yuyichao opened this issue Jan 12, 2017 · 3 comments
Assignees
Labels
parser Language parsing and surface syntax
Milestone

Comments

@yuyichao
Copy link
Contributor

I believe this is at least the second time this particular line in the PyCall.jl tests being broken by base parser change....

julia> :(try catch ex isa(ex, Exception) end)
:(try 
    catch  # REPL[1], line 1:
        ex isa (ex,Exception)
    end)

It doesn't seem valid to allow arbitrary binary operator after catch so maybe this can be unbroken?

@yuyichao yuyichao added the parser Language parsing and surface syntax label Jan 12, 2017
@ararslan
Copy link
Member

Note that it works as expected if you do

:(try catch ex; isa(ex, Exception) end)

or

:(try
  catch ex
      isa(ex, Exception)
  end)

But I agree that it seems weird to allow arbitrary binary operators after catch.

@yuyichao
Copy link
Contributor Author

yuyichao commented Jan 12, 2017

Just a reference to the last time this is broken for fun =)

#16517

edit: Actually I think it was a different line... But also one liner try catch used in PyCall...

@JeffBezanson
Copy link
Member

Fixed by #23487.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser Language parsing and surface syntax
Projects
None yet
Development

No branches or pull requests

3 participants