make a default flush(io)=nothing method for all IO streams #16403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wasn't there a recent change to make all |
|
@StefanKarpinski, ah, thanks, I didn't notice that change (#16076). Will fix. |
stevengj
changed the title
|
Is the AppVeyor failure spurious? Looks like the output just stops randomly. Trying again. |
|
Yay, tests are green. Should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there is no
flush(::IOBuffer)function, even as a no-op, which makes it error-prone to write generic code that operates onIOstreams. See JuliaPlots/Plots.jl#258 and JuliaPy/PyCall.jl#272.This PR just adds a generic
flush(io::IO)=nothingfallback method, which should be safe sinceflushis only loosely defined in terms of side effects anyway.