-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finalize printf format calling syntax #140
Comments
Shall we 2.0 this? |
No, I'm still aiming to get to this. Working on the last sections of the manual currently. After that I'm going to tackle all the printing and formatting stuff. It's hard to get any real work done without this. |
Concluded at JuliaCon 1.0day1: should probably implement plain old functions that implement the various printf formatting features, then play around with different ways of invoking them. |
This is looking pretty good. What's left to do here? |
The parsing all works, but actual printing doesn't always work. E.g. Zero padding is horribly broken, most conversion specifiers don't actually work, etc. I'll take another pass at it soon and whip it all into shape. |
We still need to finalize the API to printf. That is a breaking change. |
Next step is to benchmark the function call version, |
I kind of like |
|
I think we pretty much concluded it had to look like a normal function call or it would be too weird. The devious thing about The only remaining case is building a format string at run time, which people sometimes do. The best thing I can think of is an alternate formatting API that doesn't require parsing format strings. Hopefully it could call bits of printf's functionality. Then we can say to use that instead of building format strings. |
Other thought: maybe |
|
Ok, I like this plan. A |
Closed by 04f542d. |
Handle NaN in formatting of p-values
* An export-worthy API for break_on_error Some day we hope to have more possibilities for triggering automatic breakpoints (issue #102). For now, let's at least establish an extensible user-level API.
* --safe-crash-log-file flag * Update init.c * json escape jl_safe_printf when safe crash log file * add timestamp to json logs * port it to aarch64 darwin * fix minor warning * missing double quote * Suggestion from code review: make sig_stack_size a const in signals-unix.c Co-authored-by: Kiran Pamnany <[email protected]> * Suggestion from code review: make sig_stack size a const in signals-win.c Co-authored-by: Kiran Pamnany <[email protected]> * more suggestions from Kiran's review * more suggestions from review --------- Co-authored-by: Malte Sandstede <[email protected]> Co-authored-by: Adnan Alhomssi <[email protected]> Co-authored-by: Kiran Pamnany <[email protected]>
See #29 (comment):
The text was updated successfully, but these errors were encountered: