Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reload prints a deprecation warning #13059

Closed
JeffBezanson opened this issue Sep 10, 2015 · 9 comments
Closed

reload prints a deprecation warning #13059

JeffBezanson opened this issue Sep 10, 2015 · 9 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@JeffBezanson
Copy link
Member

It's not deprecated, so this shouldn't happen.
@JeffBezanson
Copy link
Member Author

#13052 (comment)

@yuyichao
Copy link
Contributor

In that case, we are also missing the document for reload latest doc vs release-0.3 doc

I caught this with script but didn't add it because I thought it was also deprecated along with require(::AbstractString)

@JeffBezanson JeffBezanson added the bug Indicates an unexpected problem or unintended behavior label Sep 11, 2015
@JeffBezanson
Copy link
Member Author

Actually, it's worse than this. The deprecated require does not work at all.

@ScottPJones
Copy link
Contributor

This is why I've said that deprecated functions really should have unit tests, just like any other code, and hopefully we'll get to complete coverage of them as well, like we are trying to do for the rest of base. Just because they will go away at some point in the future, doesn't mean that people don't depend on them in the meantime.

@ssfrr
Copy link
Contributor

ssfrr commented Sep 11, 2015

so does that mean that reload doesn't work right now? I've been having trouble with it lately but I've been messing around in Atom so I figured it was due to something in there.

@JeffBezanson
Copy link
Member Author

Yes, there could very well be problems with it. Post more examples of failures if you have them. require is in worse shape though. I'm working on a fix.

@ssfrr
Copy link
Contributor

ssfrr commented Sep 12, 2015

FYI with a simple module I can reproduce my issue in Atom but not in the REPL, so I think it has more to do with my understanding of how Atom.jl handles module resolution or something.

JeffBezanson added a commit that referenced this issue Sep 13, 2015
@JeffBezanson @tkelman
fix #13059, reload and require deprecations
3b43bd8 
- reload was not actually deprecated

- require(::String) now does almost exactly what it did in 0.3 (via copying
  the code). However the deprecation is oriented to the use case where the
  argument is a file path to load once, as this is not easily replaced by
  `using`.

(cherry picked from commit d3bc374)
@JeffBezanson
Copy link
Member Author

Also needs 615e746

@tkelman
Copy link
Contributor

tkelman commented Sep 15, 2015

Got it in the #13107 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yuyichao @ssfrr @JeffBezanson @tkelman @ScottPJones