Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename names to fields or fieldnames? #10325

Closed
jakebolewski opened this issue Feb 25, 2015 · 2 comments · Fixed by #10332
Closed

Rename names to fields or fieldnames? #10325

jakebolewski opened this issue Feb 25, 2015 · 2 comments · Fixed by #10332
Labels
breaking This change will break code
Milestone
0.4.0

Comments

@jakebolewski
Copy link
Member

It has been brought up in a couple of discussions that it would be useful to overload the meaning of names for user defined types, but it's current meaning in Base (return a array of symbols for field names of a given type) kind of prevents this (you would assume getfield(T, fieldnames(T)[1]) works).

Possible suggestions were to rename names to fields or fieldnames.
@ivarne
Copy link
Member

ivarne commented Feb 25, 2015

+1

@JeffBezanson
Copy link
Member

+1 fieldnames is good; we already have fieldoffsets.

@JeffBezanson JeffBezanson added the breaking This change will break code label Feb 25, 2015
@JeffBezanson JeffBezanson added this to the 0.4 milestone Feb 25, 2015
@jakebolewski jakebolewski mentioned this issue Feb 26, 2015
Merged
tanmaykm added a commit to JuliaIO/ProtoBuf.jl that referenced this issue Feb 27, 2015
@tanmaykm
track JuliaLang change for names -> fieldnames
d6d4f6f 
ref: JuliaLang/julia#10325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This change will break code
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Deprecate names for composite types in favor of fieldnames JuliaLang/julia
3 participants
@ivarne @JeffBezanson @jakebolewski