Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make RawFD a noop for passed in RawFD
this can happen in the Windows mmap code and it would be much nicer if it just worked.
- Loading branch information
fe994bb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the Windows mmap code works right now (see JuliaIO/HDF5.jl#89, and also possibly https://ci.appveyor.com/project/tkelman/json-jl/build/1.0.18/job/t1vk4i6iqxyhfa05 and https://ci.appveyor.com/project/tkelman/dataframes-jl/build/1.0.5/job/04l8e0iym1pyixy1), but I'll test again to see if this fixes it.
fe994bb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably doesn't. I just noticed this error in my Requests.jl AppVeyor logs and figured it can't hurt. There's probably more to be done.