Skip to content

Commit

Permalink
Unfortunately, Makefiles are even simpler than I thought
Browse files Browse the repository at this point in the history
  • Loading branch information
@staticfloat
staticfloat committed Apr 19, 2014
1 parent 58adf1b commit f6296a6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deps/Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ dsfmt-$(DSFMT_VER)/config.status: dsfmt-$(DSFMT_VER).tar.gz
$(TAR) -C dsfmt-$(DSFMT_VER) --strip-components 1 -xf dsfmt-$(DSFMT_VER).tar.gz && \
cd dsfmt-$(DSFMT_VER) && patch < ../dSFMT.h.patch && patch < ../dSFMT.c.patch
echo 1 > $@
$(LIBRANDOM_OBJ_SOURCE): dsfmt-$(DSFMT_VER)/config.status dsfmt-$(DSFMT_VER)/dSFMT.c
$(LIBRANDOM_OBJ_SOURCE): dsfmt-$(DSFMT_VER)/config.status
$(CC) $(CPPFLAGS) $(LIBRANDOM_CFLAGS) $(LDFLAGS) dsfmt-$(DSFMT_VER)/dSFMT.c -o librandom.$(SHLIB_EXT) && \
$(INSTALL_NAME_CMD)librandom.$(SHLIB_EXT) librandom.$(SHLIB_EXT)
$(LIBRANDOM_OBJ_TARGET): $(LIBRANDOM_OBJ_SOURCE)
Expand Down

1 comment on commit f6296a6

@staticfloat
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreasnoackjensen Just FYI, I removed the dependency on dsFMT.c because it was still causing problems similar to what we saw in #6501. Apparently changing the order of dependencies doesn't guarantee anything, and it was just a fluke that it worked that time. Whether or not having the dependency in there works seems to be dependent on when Make looks for the .c file; if it happens to be before the .status rule is run, then we're out of luck. I've just removed it since we don't really expect dsFMT.c to change that much, and that fits in with how other dependencies are doing things.

Please sign in to comment.