Skip to content

Commit

Permalink
Run ambiguity test inside a clean process; fixes 28804
Browse files Browse the repository at this point in the history
  • Loading branch information
tkf authored and Keno committed Aug 22, 2018
1 parent 6a2dcc6 commit f31e28a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions stdlib/LinearAlgebra/test/ambiguous_exec.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# This file is a part of Julia. License is MIT: https://julialang.org/license

using Test, LinearAlgebra
@test detect_ambiguities(LinearAlgebra; imported=true, recursive=true) == []
6 changes: 5 additions & 1 deletion stdlib/LinearAlgebra/test/matmul.jl
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,11 @@ end
end

@testset "method ambiguity" begin
@test detect_ambiguities(LinearAlgebra, Base; imported=true, recursive=true) == []
# Ambiguity test is run inside a clean process.
# https://github.com/JuliaLang/julia/issues/28804
script = joinpath(@__DIR__, "ambiguous_exec.jl")
cmd = `$(Base.julia_cmd()) --startup-file=no $script`
@test success(pipeline(cmd; stdout=stdout, stderr=stderr))
end

end # module TestMatmul

1 comment on commit f31e28a

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

Please sign in to comment.