Skip to content

Commit

Permalink
fix some exported undefined variables and test this does not happen (#…
Browse files Browse the repository at this point in the history
…28693)

(cherry picked from commit cc0de43)
  • Loading branch information
KristofferC committed Sep 8, 2018
1 parent 18ab3a4 commit ca151cc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
1 change: 0 additions & 1 deletion stdlib/LinearAlgebra/src/LinearAlgebra.jl
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ export
tr,
transpose,
transpose!,
transpose_type,
tril,
triu,
tril!,
Expand Down
4 changes: 1 addition & 3 deletions stdlib/Random/src/Random.jl
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ export rand!, randn!,
shuffle, shuffle!,
randperm, randperm!,
randcycle, randcycle!,
AbstractRNG, MersenneTwister, RandomDevice,
randjump

AbstractRNG, MersenneTwister, RandomDevice

## general definitions

Expand Down
8 changes: 8 additions & 0 deletions test/misc.jl
Original file line number Diff line number Diff line change
Expand Up @@ -678,3 +678,11 @@ end
# Just checking that this doesn't stack overflow on construction
@test Test27970Empty() == Test27970Empty()
end

@testset "exports of modules" begin
for (_, mod) in Base.loaded_modules
for v in names(mod)
@test isdefined(mod, v)
end
end
end

0 comments on commit ca151cc

Please sign in to comment.