Skip to content

Commit

Permalink
Distributed, SHA tests: fix soft scope shadowing (#34472)
Browse files Browse the repository at this point in the history
  • Loading branch information
@StefanKarpinski
StefanKarpinski authored Jan 22, 2020
1 parent 5c635ad commit c2abaee
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions stdlib/Distributed/test/distributed_exec.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1557,7 +1557,7 @@ nprocs()>1 && rmprocs(workers())
cluster_cookie("")

for close_stdin in (true, false), stderr_to_stdout in (true, false)
npids = addprocs_with_testenv(RetainStdioTester(close_stdin,stderr_to_stdout))
local npids = addprocs_with_testenv(RetainStdioTester(close_stdin,stderr_to_stdout))
@test remotecall_fetch(myid, npids[1]) == npids[1]
@test close_stdin != remotecall_fetch(()->isopen(stdin), npids[1])
@test stderr_to_stdout == remotecall_fetch(()->(stderr === stdout), npids[1])
Expand Down Expand Up @@ -1621,7 +1621,7 @@ a27933 = :_not_defined_27933

# PR #28651
for T in (UInt8, Int8, UInt16, Int16, UInt32, Int32, UInt64)
n = @distributed (+) for i in Base.OneTo(T(10))
local n = @distributed (+) for i in Base.OneTo(T(10))
i
end
@test n == 55
Expand Down
2 changes: 1 addition & 1 deletion stdlib/SHA/test/runtests.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ end
# test error if eltype of input is not UInt8
for f in sha_funcs
global nerrors
data = UInt32[0x23467, 0x324775]
local data = UInt32[0x23467, 0x324775]
try
f(data)
catch ex
Expand Down

4 comments on commit c2abaee

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.