Skip to content

Commit

Permalink
NEWS: strengthen warning about readline change [ci skip]
Browse files Browse the repository at this point in the history
  • Loading branch information
@StefanKarpinski
StefanKarpinski committed Jan 24, 2017
1 parent 6f677c7 commit abbd76c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions NEWS.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ Breaking changes
This section lists changes that do not have deprecation warnings.

* `readline`, `readlines` and `eachline` return lines without line endings by default.
You can use `readline(s, chomp=false)` to get the old behavior and include EOL
character(s). ([#19944]).
You *must* use `readline(s, chomp=false)`, etc. to get the old behavior where lines
returned include trailing end-of-line character(s). ([#19944])

* `String`s no longer have a `.data` field (as part of a significant performance
improvement). Use `Vector{UInt8}(str)` to access a string as a byte array.
Expand Down

1 comment on commit abbd76c

@tkelman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reads a bit unclearly, "returned lines include" might make the intended parts of speech more obvious

Please sign in to comment.