use correct size when creating output data from an IOBuffer (#54129)

PR from #54097. Fixes #54097 Co-authored-by: Nathan Zimmerberg (cherry picked from commit fda02ac)
JuliaLang · Apr 25, 2024 · 9b5f3c9 · 9b5f3c9
1 parent 08c7f9d
commit 9b5f3c9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/base/iobuffer.jl b/base/iobuffer.jl
@@ -468,7 +468,7 @@ function take!(io::IOBuffer)
         elseif io.writable
             data = view(io.data, io.offset+1:nbytes+io.offset)
         else
-            data = copyto!(StringVector(io.size), 1, io.data, io.offset + 1, nbytes)
+            data = copyto!(StringVector(nbytes), 1, io.data, io.offset + 1, nbytes)
         end
     else
         nbytes = bytesavailable(io)

diff --git a/test/iobuffer.jl b/test/iobuffer.jl
@@ -383,3 +383,8 @@ end
     seek(io,0)
     @test Base.read_sub(io,v,1,1) == [1,0]
 end
+
+@testset "with offset" begin
+    b = pushfirst!([0x02], 0x01)
+    @test take!(IOBuffer(b)) == [0x01, 0x02]
+end