bytes2hex: reimplement efficiently (close #14341)

JuliaLang · Dec 15, 2015 · 97443cd · 97443cd
1 parent 10e8b52
commit 97443cd
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/base/strings/util.jl b/base/strings/util.jl
@@ -234,4 +234,12 @@ function hex2bytes(s::AbstractString)
     return a
 end
 
-bytes2hex(arr::Vector{UInt8}) = join([hex(i,2) for i in arr])
+function bytes2hex(a::AbstractArray{UInt8})
+    b = Vector{UInt8}(2*length(a))
+    i = 0
+    for x in a
+        b[i += 1] = hex_chars[1 + x >> 4]
+        b[i += 1] = hex_chars[1 + x & 0xf]
+    end
+    return ASCIIString(b)
+end