Be less permissive with commit parent ID types

JuliaLang · Jan 7, 2017 · 92c5881 · 92c5881
1 parent 977fa7d
commit 92c5881
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/base/libgit2/commit.jl b/base/libgit2/commit.jl
@@ -51,7 +51,7 @@ function commit(repo::GitRepo, msg::AbstractString;
                 author::Signature = Signature(repo),
                 committer::Signature = Signature(repo),
                 tree_id::AbstractGitHash = GitHash(),
-                parent_ids::Vector{AbstractGitHash}=AbstractGitHash[])
+                parent_ids::GitHashVector = GitHash[])
     # Retrieve tree identifier
     if iszero(tree_id)
         tree_id = with(GitIndex, repo) do idx; write_tree!(idx) end

diff --git a/base/libgit2/types.jl b/base/libgit2/types.jl
@@ -30,6 +30,8 @@ immutable GitShortHash <: AbstractGitHash
     len::Csize_t
 end
 
+typealias GitHashVector Union{Vector{GitHash}, Vector{GitShortHash}}
+
 """
     LibGit2.TimeStruct
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,6 +30,8 @@ immutable GitShortHash <: AbstractGitHash @@
         len::Csize_t
     end
+    typealias GitHashVector Union{Vector{GitHash}, Vector{GitShortHash}}
     """
         LibGit2.TimeStruct
@@ Expand Down @@