Skip to content

Commit

Permalink
Merge pull request #22049 from JuliaLang/kf/memcpyopt
Browse files Browse the repository at this point in the history 
Add extra early memcpyopt pass
  • Loading branch information
@Keno
Keno authored May 25, 2017
2 parents 4158b5e + 7f79024 commit 8b2cac4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/jitlayers.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ void addOptimizationPasses(PassManager *PM)
// list of passes from vmkit
PM->add(createCFGSimplificationPass()); // Clean up disgusting code
PM->add(createPromoteMemoryToRegisterPass()); // Kill useless allocas
PM->add(createMemCpyOptPass());

// hopefully these functions (from llvmcall) don't try to interact with the Julia runtime
// or have anything that might corrupt the createLowerPTLSPass pass
Expand Down

6 comments on commit 8b2cac4

@KristofferC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, vs = "@4158b5ebfce628bf899fdd7f5b165bbb41cf9901")

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@martinholters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keno any ideas?

@KristofferC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo revert and then the performance fixes can be iterated on in a new PR?

@tkelman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this get addressed?

@martinholters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref. #22049 (comment)

Please sign in to comment.