Skip to content

Commit

Permalink
expose OPENBLAS_NO_AVX2 option
Browse files Browse the repository at this point in the history 
ref #7476
  • Loading branch information
@tkelman
tkelman committed Jul 25, 2014
1 parent 9d922bc commit 6163a77
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions deps/Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,9 @@ endif
ifeq ($(OPENBLAS_NO_AVX), 1)
OPENBLAS_BUILD_OPTS += NO_AVX=1
endif
ifeq ($(OPENBLAS_NO_AVX2), 1)
OPENBLAS_BUILD_OPTS += NO_AVX2=1
endif

openblas-$(OPENBLAS_VER).tar.gz:
$(JLDOWNLOAD) $@ https://github.com/xianyi/OpenBLAS/tarball/$(OPENBLAS_VER)
Expand Down

5 comments on commit 6163a77

@johnmyleswhite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for future reference, I don't think NO_AVX does much of value on CentOS 6. The magic is exclusively in NO_AVX2.

@tkelman
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not any more, with the current version of OpenBLAS. With v0.2.10.rc2 and earlier, NO_AVX turned off all optimized kernels for SandyBridge, Bulldozer, Piledriver, and Haswell. Now it only turns off the first 3, independently of NO_AVX2 which only disables Haswell. OpenMathLib/OpenBLAS@c94762b

@staticfloat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have OPENBLAS_NO_AVX imply OPENBLAS_NO_AVX2 as well; I can't imagine a situation where you'd want AVX2 but not AVX.

@tkelman
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace line 815 with OPENBLAS_BUILD_OPTS += NO_AVX2=1 and add else to the start of line 816 then?

@staticfloat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mostly looking to see if you had any objections, but yes. That would be the way to do it. ;)

Please sign in to comment.