clean up string indexing (#23799)

JuliaLang · Sep 29, 2017 · 5a5dbed · 5a5dbed
1 parent 41f3a8b
commit 5a5dbed
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/base/interactiveutil.jl b/base/interactiveutil.jl
@@ -33,8 +33,7 @@ by setting `JULIA_EDITOR`, `VISUAL` or `EDITOR` as an environment variable.
 function edit(path::AbstractString, line::Integer=0)
     command = editor()
     name = basename(first(command))
-    issrc = length(path)>2 && path[end-2:end] == ".jl"
-    if issrc
+    if endswith(path, ".jl")
         f = find_source_file(path)
         f !== nothing && (path = f)
     end

diff --git a/base/loading.jl b/base/loading.jl
@@ -103,7 +103,7 @@ function find_in_path(name::String, wd::Union{Void,String})
     isabspath(name) && return name
     base = name
     if endswith(name,".jl")
-        base = name[1:end-3]
+        base = name[1:prevind(name, end-2)]
     else
         name = string(base,".jl")
     end

diff --git a/base/profile.jl b/base/profile.jl
@@ -640,14 +640,14 @@ function rtruncto(str::String, w::Int)
     if length(str) <= w
         return str
     else
-        return string("...", str[end-w+4:end])
+        return string("...", str[chr2ind(str, length(str)-w+4):end])
     end
 end
 function ltruncto(str::String, w::Int)
     if length(str) <= w
         return str
     else
-        return string(str[1:w-4], "...")
+        return string(str[1:chr2ind(str,w-4)], "...")
     end
 end