Skip to content

Commit

Permalink
Merge pull request #29325 from JuliaLang/vc/restored
Browse files Browse the repository at this point in the history
check return from jl_restore_incremental correctly
  • Loading branch information
vchuravy authored Sep 30, 2018
2 parents f7f87c2 + f474f75 commit 4d06e00
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions base/loading.jl
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,9 @@ end
# and it reconnects the Base.Docs.META
function _include_from_serialized(path::String, depmods::Vector{Any})
sv = ccall(:jl_restore_incremental, Any, (Cstring, Any), path, depmods)
if isa(sv, Exception)
return sv
end
restored = sv[1]
if !isa(restored, Exception)
for M in restored::Vector{Any}
Expand Down

2 comments on commit 4d06e00

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.