Remove Iterators.reverse(::Tuple) specialization (#34732)

JuliaLang · Feb 14, 2020 · 48f942b · 48f942b · nanosoldier · Feb 15, 2020
1 parent 438485e
commit 48f942b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/base/iterators.jl b/base/iterators.jl
@@ -98,7 +98,6 @@ reverse(G::Generator) = Generator(G.f, reverse(G.iter))
 reverse(r::Reverse) = r.itr
 reverse(x::Union{Number,AbstractChar}) = x
 reverse(p::Pair) = Base.reverse(p) # copying pairs is cheap
-reverse(xs::Tuple) = Base.reverse(xs) # allows inference in mapfoldr and similar
 
 iterate(r::Reverse{<:Tuple}, i::Int = length(r.itr)) = i < 1 ? nothing : (r.itr[i], i-1)
 

diff --git a/base/reduce.jl b/base/reduce.jl
@@ -178,9 +178,12 @@ foldl(op, itr; kw...) = mapfoldl(identity, op, itr; kw...)
 
 function mapfoldr_impl(f, op, nt, itr)
     op′, itr′ = _xfadjoint(BottomRF(FlipArgs(op)), Generator(f, itr))
-    return foldl_impl(op′, nt, Iterators.reverse(itr′))
+    return foldl_impl(op′, nt, _reverse(itr′))
 end
 
+_reverse(itr) = Iterators.reverse(itr)
+_reverse(itr::Tuple) = reverse(itr)  #33235
+
 struct FlipArgs{F}
     f::F
 end