Merge pull request #25729 from JuliaLang/vc/fixup_bitarray

fixup `copyto!(::BitArray, [])`
JuliaLang · Jan 24, 2018 · 18be1f2 · 18be1f2
2 parents e0ad15a + 2d6e75c
commit 18be1f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/base/bitarray.jl b/base/bitarray.jl
@@ -431,7 +431,7 @@ end
 
 function copyto!(dest::BitArray, src::Array)
     length(src) > length(dest) && throw(BoundsError(dest, length(dest)+1))
-    length(src) == 0 && return det
+    length(src) == 0 && return dest
     return unsafe_copyto!(dest, 1, src, 1, length(src))
 end
 

diff --git a/test/bitarray.jl b/test/bitarray.jl
@@ -111,6 +111,9 @@ timesofar("conversions")
     end
 
     @testset "copyto!" begin
+        let b1 = trues(1)
+            @test all(copyto!(b1, []))
+        end
         for n in [1; 1023:1025]
             b1 = falses(n)
             for m in [1; 10; 1023:1025]