Merge pull request #49397 from JuliaLang/kf/verifycontrol

irverify: Catch invalid use of Goto{IfNot, Node}, ReturnNode
JuliaLang · Apr 18, 2023 · 1512d6f · 1512d6f
2 parents 386b09f + 7c80f25
commit 1512d6f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/base/compiler/ssair/verify.jl b/base/compiler/ssair/verify.jl
@@ -43,6 +43,12 @@ function check_op(ir::IRCode, domtree::DomTree, @nospecialize(op), use_bb::Int,
                 error("")
             end
         end
+
+        use_inst = ir[op]
+        if isa(use_inst[:inst], Union{GotoIfNot, GotoNode, ReturnNode})
+            @verify_error "At statement %$use_idx: Invalid use of value statement or terminator %$(op.id)"
+            error("")
+        end
     elseif isa(op, GlobalRef)
         if !isdefined(op.mod, op.name) || !isconst(op.mod, op.name)
             @verify_error "Unbound GlobalRef not allowed in value position"