Change reduced_index for Slices and add test for previously failing

maximum of OffsetArray example
JuliaLang · Jul 13, 2018 · 0c1137c · 0c1137c
1 parent fe68641
commit 0c1137c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/base/reducedim.jl b/base/reducedim.jl
@@ -4,7 +4,7 @@
 
 # for reductions that expand 0 dims to 1
 reduced_index(i::OneTo) = OneTo(1)
-reduced_index(i::Slice) = Slice(first(i):first(i))
+reduced_index(i::Slice) = first(i):first(i)
 reduced_index(i::AbstractUnitRange) =
     throw(ArgumentError(
 """

diff --git a/test/offsetarray.jl b/test/offsetarray.jl
@@ -484,3 +484,8 @@ module SimilarUR
     @test_throws MethodError similar(a, Float64, (ur,))
     @test_throws MethodError similar(a, (2.0,3.0))
 end
+
+@testset "Issue 28101" begin
+    A = OffsetArray(reshape(16:-1:1, (4, 4)), (-3,5))
+    @test maximum(A, dims=1) == OffsetArray(maximum(parent(A), dims=1), A.offsets)
+end