Skip to content

Commit

Permalink
infer_compilation_signatures for more cases (#56495)
Browse files Browse the repository at this point in the history
This seems to have negligible impact on size or performance, but makes
code quality much better.
  • Loading branch information
vtjnash authored Nov 12, 2024
1 parent 366a38e commit 001c666
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions Compiler/src/abstractinterpretation.jl
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,9 @@ function abstract_call_gf_by_type(interp::AbstractInterpreter, @nospecialize(f),
rettype = from_interprocedural!(interp, rettype, sv, arginfo, conditionals)

# Also considering inferring the compilation signature for this method, so
# it is available to the compiler in case it ends up needing it.
# it is available to the compiler in case it ends up needing it for the invoke.
if (isa(sv, InferenceState) && infer_compilation_signature(interp) &&
(seenall && 1 == napplicable) && rettype !== Any && rettype !== Bottom &&
!is_removable_if_unused(all_effects))
(seenall && 1 == napplicable) && !is_removable_if_unused(all_effects))
(; match) = applicable[1]
method = match.method
sig = match.spec_types
Expand Down

4 comments on commit 001c666

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@vtjnash
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

Please sign in to comment.