Skip to content

Fix manifest validation issue #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanButterworth merged 4 commits into from
Dec 11, 2025
Merged

Fix manifest validation issue #4541

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e35a000
tryfix
IanButterworth Nov 26, 2025
b95df49
fix understanding doc
IanButterworth Nov 26, 2025
f18b1e4
Delete BUG_ANALYSIS.md
IanButterworth Dec 9, 2025
acad351
Merge branch 'master' into ib/resolve_tryfix
IanButterworth Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Operations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,13 +850,19 @@ function resolve_versions!(
push!(pkgs, PackageSpec(; name = name, uuid = uuid, version = ver))
end
end

# Collect all UUIDs that will be in the manifest
pkgs_uuids = Set{UUID}(pkg.uuid for pkg in pkgs)

final_deps_map = Dict{UUID, Dict{String, UUID}}()
for pkg in pkgs
load_tree_hash!(registries, pkg, julia_version)
deps = begin
if pkg.uuid in keys(fixed)
deps_fixed = Dict{String, UUID}()
for dep in keys(fixed[pkg.uuid].requires)
# Only include deps that are actually in the manifest
dep in pkgs_uuids || continue
deps_fixed[names[dep]] = dep
end
deps_fixed
Expand All @@ -871,6 +877,8 @@ function resolve_versions!(
pkg.uuid, pkg.version
)
for uuid in deps_for_version
# Only include deps that are actually in the manifest
uuid in pkgs_uuids || continue
d[names[uuid]] = uuid
end
d
Expand Down