Skip to content

add support for bracket functionality when that lands in Julia #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 1 commit into from
Oct 17, 2025
Merged

add support for bracket functionality when that lands in Julia #4423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions ext/REPLExt/REPLExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ include("compat.jl")
# REPL mode creation #
######################

const BRACKET_INSERT_SUPPORTED = hasfield(REPL.Options, :auto_insert_closing_bracket)

struct PkgCompletionProvider <: LineEdit.CompletionProvider end

function LineEdit.complete_line(c::PkgCompletionProvider, s; hint::Bool = false)
Expand Down Expand Up @@ -181,10 +183,11 @@ function create_mode(repl::REPL.AbstractREPL, main::LineEdit.Prompt)
end
end

b = Dict{Any, Any}[
skeymap, repl_keymap, mk, prefix_keymap, LineEdit.history_keymap,
LineEdit.default_keymap, LineEdit.escape_defaults,
]
b = Dict{Any, Any}[skeymap, repl_keymap]
if BRACKET_INSERT_SUPPORTED && repl.options.auto_insert_closing_bracket
push!(b, LineEdit.bracket_insert_keymap)
end
push!(b, mk, prefix_keymap, LineEdit.history_keymap, LineEdit.default_keymap, LineEdit.escape_defaults)
pkg_mode.keymap_dict = LineEdit.keymap(b)
return pkg_mode
end
Expand All @@ -195,14 +198,18 @@ function repl_init(repl::REPL.LineEditREPL)
push!(repl.interface.modes, pkg_mode)
keymap = Dict{Any, Any}(
']' => function (s, args...)
return if isempty(s) || position(LineEdit.buffer(s)) == 0
if isempty(s) || position(LineEdit.buffer(s)) == 0
buf = copy(LineEdit.buffer(s))
LineEdit.transition(s, pkg_mode) do
return LineEdit.transition(s, pkg_mode) do
LineEdit.state(s, pkg_mode).input_buffer = buf
end
else
LineEdit.edit_insert(s, ']')
LineEdit.check_show_hint(s)
if BRACKET_INSERT_SUPPORTED && repl.options.auto_insert_closing_bracket
return LineEdit.bracket_insert_keymap[']'](s, args...)
else
LineEdit.edit_insert(s, ']')
return LineEdit.check_show_hint(s)
end
end
end
)
Expand Down