Skip to content

Fix historical stdlib fixup if Pkg is in the Manifest #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 1 commit into from
Jun 20, 2025
Merged

Fix historical stdlib fixup if Pkg is in the Manifest #4264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Operations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ function fixups_from_projectfile!(ctx::Context)
# pkg.exts = p.exts # TODO: STDLIBS_BY_VERSION doesn't record this
# pkg.entryfile = p.entryfile # TODO: STDLIBS_BY_VERSION doesn't record this
for (name, _) in pkg.weakdeps
if !haskey(p.deps, name)
if !(name in p.deps)
delete!(pkg.deps, name)
end
end
Expand Down
5 changes: 5 additions & 0 deletions test/historical_stdlib_version.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,11 @@ isolate(loaded_depot=true) do
end
end

@testset "Old Pkg add regression" begin
Pkg.activate(temp=true)
Pkg.add(; name="Pkg", julia_version=v"1.11")
end

@testset "Stdlib add" begin
Pkg.activate(temp=true)
# Stdlib add (current julia version)
Expand Down