Skip to content

prompt for confirmation before removing compat entry #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanButterworth merged 1 commit into from
Jun 27, 2025
Merged

prompt for confirmation before removing compat entry #4254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/API.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,12 +1408,22 @@ function compat(ctx::Context, pkg::String, compat_str::Union{Nothing,String}; io
io = something(io, ctx.io)
pkg = pkg == "Julia" ? "julia" : pkg
isnothing(compat_str) || (compat_str = string(strip(compat_str, '"')))
existing_compat = Operations.get_compat_str(ctx.env.project, pkg)
# Double check before deleting a compat entry issue/3567
if isinteractive() && (isnothing(compat_str) || isempty(compat_str))
if !isnothing(existing_compat)
ans = Base.prompt(stdin, ctx.io, "No compat string was given. Delete existing compat entry `$pkg = $(repr(existing_compat))`? [y]/n", default = "y")
if lowercase(ans) !== "y"
return
end
end
end
if haskey(ctx.env.project.deps, pkg) || pkg == "julia"
success = Operations.set_compat(ctx.env.project, pkg, isnothing(compat_str) ? nothing : isempty(compat_str) ? nothing : compat_str)
success === false && pkgerror("invalid compat version specifier \"$(compat_str)\"")
write_env(ctx.env)
if isnothing(compat_str) || isempty(compat_str)
printpkgstyle(io, :Compat, "entry removed for $(pkg)")
printpkgstyle(io, :Compat, "entry removed:\n $pkg = $(repr(existing_compat))")
else
printpkgstyle(io, :Compat, "entry set:\n $(pkg) = $(repr(compat_str))")
end
Expand Down