Skip to content

Conversation

@IanButterworth
Copy link
Member

This was sometimes breaking up printing so the test failed. i.e.

Installed 2025-03-29T21:02:12.769
artifact FFMPEG                10.6 MiB

@IanButterworth
Copy link
Member Author

IanButterworth commented Mar 30, 2025

I guess printpkgstyle could have been more robust against this by not yielding the io between these two prints, but I'm not sure how to achieve that

Pkg.jl/src/utils.jl

Lines 5 to 6 in 07235d0

printstyled(io, lpad(string(cmd), indent), color=color, bold=true)
println(io, " ", text)

@DilumAluthge
Copy link
Member

Is there a way for us to "lock" the io?

@IanButterworth
Copy link
Member Author

@IanButterworth IanButterworth changed the title Disable debug print that made test flaky Lock io within printpkgstyle to avoid print tearing Mar 30, 2025
@IanButterworth IanButterworth merged commit 895e9d3 into JuliaLang:master Mar 30, 2025
9 checks passed
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@KristofferC KristofferC mentioned this pull request Mar 31, 2025
7 tasks
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@KristofferC KristofferC mentioned this pull request Mar 31, 2025
9 tasks
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@KristofferC KristofferC mentioned this pull request Mar 31, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants